[exporter/otlphttpexporter] Partial success HTTP response handling #8270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ignore responses not encoded as protobuf
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #8270 +/- ##
==========================================
- Coverage 90.27% 90.18% -0.10%
==========================================
Files 301 302 +1
Lines 15596 15775 +179
==========================================
+ Hits 14080 14227 +147
- Misses 1227 1254 +27
- Partials 289 294 +5
☔ View full report in Codecov by Sentry. |
rmfitzpatrick
approved these changes
Aug 23, 2023
|
@evan-bradley would you please take a look as well? |
dmitryax
approved these changes
Aug 23, 2023
| func metricsPartialSuccessHandler(protoBytes []byte) error { | ||
| func metricsPartialSuccessHandler(protoBytes []byte, contentType string) error { | ||
| if contentType != protobufContentType { | ||
| return nil |
There was a problem hiding this comment.
@atoulme Why ignore the response if it is not Protobuf? It can be OTLP/JSON which is a valid content type and which can be decoded, right?
There was a problem hiding this comment.
Nevermind, I see OTLP/JSON is not yet implemented by this exporter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix the handling of the HTTP response to ignore responses not encoded as protobuf
Link to tracking Issue:
Fixes #8263