Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata.yaml as a requirement #7876

Closed

Conversation

mackjmr
Copy link
Member

@mackjmr mackjmr commented Jun 13, 2023

Description:

This PR adds the metadata.yaml as a requirement in the contributing guidelines.

Link to tracking Issue:

open-telemetry/opentelemetry-collector-contrib#20908.

This PR adds the metadata.yaml as a requirement in the contributing guidelines.

Fixes: open-telemetry/opentelemetry-collector-contrib#20908.
@mackjmr mackjmr requested review from a team and codeboten June 13, 2023 13:13
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (880e47c) 91.14% compared to head (d4e04b4) 91.14%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7876   +/-   ##
=======================================
  Coverage   91.14%   91.14%           
=======================================
  Files         298      298           
  Lines       14915    14915           
=======================================
  Hits        13594    13594           
  Misses       1045     1045           
  Partials      276      276           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mackjmr
Copy link
Member Author

mackjmr commented Jun 13, 2023

Can this get a skip changelog label ?

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repo isn't using the metadata.yml yet. I suggest we close this until the components in this repo start mdatagen

@mackjmr mackjmr closed this Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants