-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add feature gate for supporting additional exporters #7678
Merged
codeboten
merged 2 commits into
open-telemetry:main
from
codeboten:codeboten/add-featuregate-telemetry
May 16, 2023
Merged
add feature gate for supporting additional exporters #7678
codeboten
merged 2 commits into
open-telemetry:main
from
codeboten:codeboten/add-featuregate-telemetry
May 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the feature-gate `telemetry.useOtelWithExtendedConfigurationForInternalTelemetry` to start adding support for additional exporters for the collector's internal telemetry. Signed-off-by: Alex Boten <aboten@lightstep.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #7678 +/- ##
==========================================
- Coverage 91.31% 91.27% -0.05%
==========================================
Files 296 296
Lines 14485 14487 +2
==========================================
- Hits 13227 13223 -4
- Misses 995 1000 +5
- Partials 263 264 +1
☔ View full report in Codecov by Sentry. |
Signed-off-by: Alex Boten <aboten@lightstep.com>
TylerHelmuth
approved these changes
May 15, 2023
djaglowski
approved these changes
May 16, 2023
codeboten
pushed a commit
that referenced
this pull request
Jun 22, 2023
This is generated from the opentelemetry-configuration repository using gojsonschema. Updated makefile to support this w/ `make genjsonschema` Follow up to #7678 --------- Signed-off-by: Alex Boten <aboten@lightstep.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the feature-gate
telemetry.useOtelWithExtendedConfigurationForInternalTelemetry
to start adding support for additional exporters for the collector's internal telemetry.This is part of of #7644