[featuregate] Finalizing purpose of ToVersion. #7626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #7626 +/- ##
=======================================
Coverage 91.23% 91.23%
=======================================
Files 296 296
Lines 14472 14473 +1
=======================================
+ Hits 13203 13204 +1
Misses 1004 1004
Partials 265 265
☔ View full report in Codecov by Sentry. |
MovieStoreGuy
approved these changes
May 4, 2023
bogdandrutu
approved these changes
May 4, 2023
bogdandrutu
approved these changes
May 4, 2023
codeboten
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Finalizes the purpose of
toVersion.toVersionwill represent the version where the feature gate is completely removed. Setting astablegate totruewill result in a warning log. Setting astablegate tofalsewill result in an error.Link to tracking Issue:
Closes #7621
Testing:
Updated tests.
Documentation:
Updated docs.