[config/confighttp] Ensure Auth happens after compression #7574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When request signing-based authentication extensions are used it is necessary to ensure that the Auth RoundTripper is the innermost as changes to the request by other RoundTrippers (such as compression or headers) may invalidate the request signature. This change will ensure that the Auth RoundTripper is invoked after all others and is followed directly by the http.Transport. Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
Aneurysm9
force-pushed
the
fix/configHTTPAuth
branch
from
813c008
to
331e786
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #7574 +/- ##
=======================================
Coverage 91.19% 91.20%
=======================================
Files 296 296
Lines 14441 14445 +4
=======================================
+ Hits 13170 13174 +4
Misses 1006 1006
Partials 265 265
☔ View full report in Codecov by Sentry. |
bogdandrutu
approved these changes
Apr 26, 2023
| @@ -336,15 +366,34 @@ func TestHTTPClientSettingWithAuthConfig(t *testing.T) { | |||
| } | |||
| for _, test := range tests { | |||
| t.Run(test.name, func(t *testing.T) { | |||
| client, err := test.settings.ToClient(test.host, componenttest.NewNopTelemetrySettings()) | |||
| // Omit TracerProvider and MeterProvider in TelemetrySettings as otelhttp.Transport cannot be introspected | |||
| client, err := test.settings.ToClient(test.host, component.TelemetrySettings{Logger: zap.NewNop(), MetricsLevel: configtelemetry.LevelNone}) | |||
There was a problem hiding this comment.
use componenttest to create the TelemetrySettings?
There was a problem hiding this comment.
As noted in the comment the otelhttp.Transport doesn't export the RoundTripper that it wraps and so there would be no way to test the containment order beyond that transport if the componenttest.NewNopTelemetrySettings() were used.
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
codeboten
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When request signing-based authentication extensions are used it is necessary to ensure that the Auth RoundTripper is the innermost as changes to the request by other RoundTrippers (such as compression or headers) may invalidate the request signature. This change will ensure that the Auth RoundTripper is invoked after all others and is followed directly by the http.Transport.