Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the otel opencensus bridge #7483

Merged
merged 2 commits into from
Apr 11, 2023

Conversation

codeboten
Copy link
Contributor

This change configures the opencensus bridge when useOtelForInternalMetrics is enabled. This allows us to stop relying on prometheus as the bridge.

This change configures the opencensus bridge when useOtelForInternalMetrics is enabled. This allows us to stop relying on prometheus as the bridge.

Signed-off-by: Alex Boten <aboten@lightstep.com>
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Patch coverage: 50.00% and no project coverage change.

Comparison is base (b2961b7) 91.15% compared to head (fd74496) 91.15%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7483   +/-   ##
=======================================
  Coverage   91.15%   91.15%           
=======================================
  Files         295      295           
  Lines       14362    14365    +3     
=======================================
+ Hits        13092    13095    +3     
  Misses       1002     1002           
  Partials      268      268           
Impacted Files Coverage Δ
service/telemetry.go 88.13% <50.00%> (+0.20%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@codeboten codeboten merged commit a27fb4c into open-telemetry:main Apr 11, 2023
@codeboten codeboten deleted the codeboten/oc-bridge branch April 11, 2023 15:08
@github-actions github-actions bot added this to the next release milestone Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants