add semantic conventions for specification v1.17.0 #7171
Conversation
|
Can you make a similar change to open-telemetry/opentelemetry-go#3697? There's a new type of convention to generate. |
|
yes 👍 |
frzifus
force-pushed
the
semconv_v1.17.0
branch
2 times, most recently
from
6d1806d to
edc1844
Compare
Codecov ReportBase: 90.84% // Head: 90.99% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #7171 +/- ##
==========================================
+ Coverage 90.84% 90.99% +0.14%
==========================================
Files 293 293
Lines 14302 14271 -31
==========================================
- Hits 12993 12986 -7
+ Misses 1041 1017 -24
Partials 268 268
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
frzifus
force-pushed
the
semconv_v1.17.0
branch
from
edc1844 to
f866391
Compare
|
Need to adapt the tests. |
|
I will try to have a look in the coming hours. |
frzifus
force-pushed
the
semconv_v1.17.0
branch
from
f866391 to
e5c691e
Compare
semconv/semconv_test.go
Outdated
|
|
||
| end := len(expectedFiles) | ||
| switch f.Name() { | ||
| case "v1.17.0": // no nonstandard.go file requiered. |
There was a problem hiding this comment.
it might not be the ideal solution. But I thought a versions comparison with e.g. github.com/hashicorp/go-version would be an overkill. Alternatively we could just add a file without extra constants.
whats your thoughts on it?
Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
frzifus
force-pushed
the
semconv_v1.17.0
branch
from
e5c691e to
fe1cffd
Compare
Link to tracking Issue:
Closes #7170