Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate featuregate.Registry.List in favor of Visit. #7041

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Base: 89.94% // Head: 89.88% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (9a6f1ab) compared to base (6723312).
Patch coverage: 27.27% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7041      +/-   ##
==========================================
- Coverage   89.94%   89.88%   -0.06%     
==========================================
  Files         245      245              
  Lines       14712    14723      +11     
==========================================
+ Hits        13232    13234       +2     
- Misses       1210     1218       +8     
- Partials      270      271       +1     
Impacted Files Coverage Δ
service/zpages.go 64.00% <0.00%> (ø)
featuregate/registry.go 70.65% <42.85%> (-7.13%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bogdandrutu bogdandrutu merged commit cf9c829 into open-telemetry:main Jan 27, 2023
@bogdandrutu bogdandrutu deleted the addvisit branch January 27, 2023 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants