Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add private method to GrpcServer interface, disallow direct implementation #7029

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Add private method to GrpcServer interface, disallow direct implementation #7029

merged 1 commit into from
Jan 27, 2023

Conversation

bogdandrutu
Copy link
Member

Fixes #6966

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

@bogdandrutu
Add private method to GrpcServer interface, disallow direct implement…
ba3aae3 
…ation

Fixes open-telemetry#6966

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu requested review from a team and jpkrohling January 26, 2023 01:14
@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Base: 90.33% // Head: 90.31% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (ba3aae3) compared to base (af15118).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7029      +/-   ##
==========================================
- Coverage   90.33%   90.31%   -0.02%     
==========================================
  Files         245      245              
  Lines       14644    14647       +3     
==========================================
  Hits        13229    13229              
- Misses       1146     1149       +3     
  Partials      269      269
Impacted Files Coverage Δ
pdata/plog/plogotlp/grpc.go 73.33% <0.00%> (-5.24%) ⬇️
pdata/pmetric/pmetricotlp/grpc.go 73.33% <0.00%> (-5.24%) ⬇️
pdata/ptrace/ptraceotlp/grpc.go 73.33% <0.00%> (-5.24%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

jpkrohling
jpkrohling approved these changes Jan 26, 2023
View reviewed changes
Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but aren't there any implementations of it in this project? Not even as tests?

@bogdandrutu
Copy link
Member Author

Looks good, but aren't there any implementations of it in this project? Not even as tests?

They are, but I did it in 2 steps (as suggested). Last release I added the "Unimplemented*", used it, and add a comment to embed it (since cannot use deprecation notice). Then now I am enforcing that :)

@bogdandrutu
Copy link
Member Author

@mx-psi let me know when you fix DD :)

@mx-psi
Copy link
Member

mx-psi commented Jan 27, 2023

I will try to get the DD fix done today and updated on contrib by Monday :)

@mx-psi mx-psi mentioned this pull request Jan 27, 2023
Merged
@mx-psi
Copy link
Member

mx-psi commented Jan 27, 2023

open-telemetry/opentelemetry-collector-contrib/pull/18074 will unblock this

@bogdandrutu bogdandrutu merged commit e520829 into open-telemetry:main Jan 27, 2023
@bogdandrutu bogdandrutu deleted the fixgrpc branch January 27, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpkrohling jpkrohling jpkrohling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide a mechanism to allow adding new methods on the gRPC services
3 participants
@bogdandrutu @mx-psi @jpkrohling