-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add connector validation to otelcol #7001
Add connector validation to otelcol #7001
Conversation
058104f
to
362ed2d
Compare
Codecov ReportBase: 90.38% // Head: 90.37% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #7001 +/- ##
==========================================
- Coverage 90.38% 90.37% -0.01%
==========================================
Files 243 243
Lines 14575 14597 +22
==========================================
+ Hits 13173 13192 +19
- Misses 1133 1136 +3
Partials 269 269
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just perhaps one error message could be improved.
Co-authored-by: Juraci Paixão Kröhling <juraci.github@kroehling.de>
60ef9f6
to
2db6b73
Compare
Part of #6700
This PR finishes adding connectors to the otelcol config including validation. Validation for connectors is the same as with other components, except two additional checks are included: