Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release v0.69.1 #6934

Merged

Conversation

djaglowski
Copy link
Member

This does not bump the RC version, as no modules with that tag are affected.

@djaglowski djaglowski marked this pull request as ready for review January 12, 2023 14:31
@djaglowski djaglowski requested review from a team and Aneurysm9 and removed request for a team January 12, 2023 14:31
@djaglowski
Copy link
Member Author

djaglowski commented Jan 12, 2023

Test failure is #6759

panic: sync: negative WaitGroup counter

goroutine 170 [running]:
sync.(*WaitGroup).Add(0xc000046ad0, 0xffffffffffffffff)
	/opt/hostedtoolcache/go/1.18.9/x64/src/sync/waitgroup.go:80 +0x1f8
sync.(*WaitGroup).Done(...)
	/opt/hostedtoolcache/go/1.18.9/x64/src/sync/waitgroup.go:105
go.opentelemetry.io/collector/exporter/exporterhelper.(*observabilityConsumerSender).send(0xc000093170, {0x1292c20, 0xc000032040})
	/home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/queued_retry_test.go:688 +0x108
go.opentelemetry.io/collector/exporter/exporterhelper.(*queuedRetrySender).start.func1({0x1292c20, 0xc000032040})
	/home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/queued_retry.go:205 +0x65
go.opentelemetry.io/collector/exporter/exporterhelper/internal.(*boundedMemoryQueue).StartConsumers.func1()
	/home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/internal/bounded_memory_queue.go:61 +0x144
created by go.opentelemetry.io/collector/exporter/exporterhelper/internal.(*boundedMemoryQueue).StartConsumers
	/home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/internal/bounded_memory_queue.go:56 +0x68
FAIL	go.opentelemetry.io/collector/exporter/exporterhelper	0.395s

@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release/v0.69.x@ea8eb18). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@                Coverage Diff                 @@
##             release/v0.69.x    #6934   +/-   ##
==================================================
  Coverage                   ?   91.05%           
==================================================
  Files                      ?      237           
  Lines                      ?    14298           
  Branches                   ?        0           
==================================================
  Hits                       ?    13019           
  Misses                     ?     1027           
  Partials                   ?      252           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I wonder if there's a way for us to ensure this does not happen again in the future. Perhaps a script that would ensure all dependencies for "go.opentelemetry.io/collector" are at the same version, except for pdata?

connector/forwardconnector/go.mod Show resolved Hide resolved
@djaglowski djaglowski merged commit b6571e0 into open-telemetry:release/v0.69.x Jan 12, 2023
@djaglowski djaglowski deleted the release/v0.69.1-prep branch January 12, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants