Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Fix panic in queue_retry tests #6807

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

dmitryax
Copy link
Member

Fixes #6759

The tests helpers for obsreport should be reworked, but this one is a quick fix that should prevent it from panicking.

@dmitryax dmitryax marked this pull request as ready for review December 15, 2022 19:29
@dmitryax dmitryax requested review from a team and bogdandrutu December 15, 2022 19:29
@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Base: 90.08% // Head: 90.08% // No change to project coverage 👍

Coverage data is based on head (2074518) compared to base (cfa49fc).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6807   +/-   ##
=======================================
  Coverage   90.08%   90.08%           
=======================================
  Files         246      246           
  Lines       14246    14246           
=======================================
  Hits        12834    12834           
  Misses       1163     1163           
  Partials      249      249           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dmitryax dmitryax changed the title [chore] Fix panic caused by queue_retry tests [chore] Fix panic in queue_retry tests Dec 15, 2022
@bogdandrutu bogdandrutu merged commit c1e1ea2 into open-telemetry:main Dec 15, 2022
@dmitryax dmitryax deleted the fix-tests-panic branch December 16, 2022 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exporterhelper test panic after #6693
2 participants