Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Get prefix funcs for featuregate.Gate #6528

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

bogdandrutu
Copy link
Member

No description provided.

@bogdandrutu bogdandrutu requested review from a team and dmitryax November 11, 2022 21:10
@bogdandrutu bogdandrutu force-pushed the deprecateget branch 2 times, most recently from 7dff88e to dbc2e4a Compare November 11, 2022 21:13
@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Base: 91.32% // Head: 91.29% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (20e9967) compared to base (b3c8744).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6528      +/-   ##
==========================================
- Coverage   91.32%   91.29%   -0.03%     
==========================================
  Files         241      242       +1     
  Lines       13878    13882       +4     
==========================================
  Hits        12674    12674              
- Misses        959      963       +4     
  Partials      245      245              
Impacted Files Coverage Δ
featuregate/registry.go 100.00% <ø> (ø)
service/zpages.go 64.00% <0.00%> (ø)
featuregate/gate.go 75.00% <75.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu merged commit 65152ee into open-telemetry:main Nov 11, 2022
@bogdandrutu bogdandrutu deleted the deprecateget branch November 11, 2022 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants