Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare v0.64.0 #6503

Merged
merged 5 commits into from
Nov 9, 2022
Merged

Prepare v0.64.0 #6503

merged 5 commits into from
Nov 9, 2022

Conversation

jpkrohling
Copy link
Member

Closes #6496

Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de

@jpkrohling jpkrohling requested review from a team and Aneurysm9 November 8, 2022 19:41
@jpkrohling jpkrohling marked this pull request as draft November 8, 2022 19:41
@jpkrohling
Copy link
Member Author

Converted to draft as I want to verify contrib builds with the latest core.

codeboten
codeboten reviewed Nov 8, 2022
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like any go.mod files were updated as part of the PR

@codecov
Copy link

codecov bot commented Nov 8, 2022 •
edited
Loading

Codecov Report

Base: 91.66% // Head: 91.66% // No change to project coverage 👍

Coverage data is based on head (f3ff002) compared to base (eac9944).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6503   +/-   ##
=======================================
  Coverage   91.66%   91.66%           
=======================================
  Files         240      240           
  Lines       13815    13815           
=======================================
  Hits        12663    12663           
  Misses        921      921           
  Partials      231      231
Impacted Files Coverage Δ
cmd/builder/internal/builder/config.go 68.49% <ø> (ø)
cmd/otelcorecol/main.go 0.00% <0.00%> (ø)
confmap/resolver.go 96.34% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jpkrohling
Copy link
Member Author

It doesn't look like any go.mod files were updated as part of the PR

Looking at the target and later at the logs, it looks like it failed in the multimod step. I'll try to run it manually and see if I can update this PR.

@jpkrohling jpkrohling force-pushed the opentelemetry-collector-bot/release-0.64.0 branch from fbd4a9b to 39af2a6 Compare November 8, 2022 19:53
@jpkrohling
changelog entries
f3ff002 
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@jpkrohling
Copy link
Member Author

This looks better now, cloning it on a fresh local repository made it work.

@jpkrohling jpkrohling added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 8, 2022
@jpkrohling jpkrohling marked this pull request as ready for review November 8, 2022 21:37
@jpkrohling jpkrohling marked this pull request as draft November 8, 2022 21:51
@jpkrohling jpkrohling marked this pull request as ready for review November 9, 2022 01:44
@bogdandrutu bogdandrutu merged commit 226dc13 into open-telemetry:main Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@codeboten codeboten codeboten approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prepare core release v0.64.0
3 participants
@jpkrohling @codeboten @bogdandrutu