Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cgroups: accurate procfs parsing #6462

Merged
merged 1 commit into from
Nov 2, 2022
Merged

cgroups: accurate procfs parsing #6462

merged 1 commit into from
Nov 2, 2022

Conversation

rockdrilla
Copy link
Contributor

Description: split line into exactly 3 parts while parsing /proc/{pid}/cgroup.

Link to tracking Issue: #6389

Testing: None

Documentation: None

@rockdrilla rockdrilla requested review from a team and dmitryax November 2, 2022 09:23
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 2, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: rockdrilla / name: Konstantin Demin (d29c947)

@bogdandrutu
Copy link
Member

/cc @dashpole

@dashpole
Copy link
Contributor

dashpole commented Nov 2, 2022

Can you add a test using the output from the bug report?

@rockdrilla
Copy link
Contributor Author

@dashpole done.

@dmitryax
Copy link
Member

dmitryax commented Nov 2, 2022

@rockdrilla thanks for the contribution! Can you please add a changelog entry?

@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Base: 91.86% // Head: 91.86% // No change to project coverage 👍

Coverage data is based on head (cc61f0d) compared to base (62f4388).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6462   +/-   ##
=======================================
  Coverage   91.86%   91.86%           
=======================================
  Files         237      237           
  Lines       13620    13620           
=======================================
  Hits        12512    12512           
  Misses        879      879           
  Partials      229      229           
Impacted Files Coverage Δ
internal/cgroups/subsys.go 92.30% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rockdrilla
Copy link
Contributor Author

@dmitryax I'm afraid I can't express that change in "human" words better than any of existing contributors. :)

@rockdrilla
Copy link
Contributor Author

Got it, wait a minute.

@dmitryax
Copy link
Member

dmitryax commented Nov 2, 2022

Just create a file in https://github.com/open-telemetry/opentelemetry-collector/tree/main/.chloggen with a few words like Fixed Cgroup v1 initialization for memory_ballast extension with a link to the issue.

fixes #6389

Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
@bogdandrutu bogdandrutu merged commit 2898493 into open-telemetry:main Nov 2, 2022
@rockdrilla rockdrilla deleted the issue-6389 branch November 6, 2022 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants