Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide better helpers for configgrpc, consistent with confighttp #6441

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

bogdandrutu
Copy link
Member

Deprecate old ToDialOptions and ToServerOptions.

@bogdandrutu bogdandrutu marked this pull request as ready for review October 28, 2022 23:49
@bogdandrutu bogdandrutu requested review from a team and Aneurysm9 October 28, 2022 23:49
@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Base: 91.82% // Head: 92.02% // Increases project coverage by +0.20% 🎉

Coverage data is based on head (b6cdd2a) compared to base (5a7ddf1).
Patch coverage: 90.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6441      +/-   ##
==========================================
+ Coverage   91.82%   92.02%   +0.20%     
==========================================
  Files         237      237              
  Lines       13549    13534      -15     
==========================================
+ Hits        12441    12455      +14     
+ Misses        882      854      -28     
+ Partials      226      225       -1     
Impacted Files Coverage Δ
pdata/plog/json.go 100.00% <ø> (+26.66%) ⬆️
pdata/plog/pb.go 100.00% <ø> (+28.57%) ⬆️
pdata/plog/plogotlp/grpc.go 100.00% <ø> (ø)
pdata/plog/plogotlp/request.go 50.00% <ø> (ø)
pdata/plog/plogotlp/response.go 12.50% <ø> (ø)
pdata/pmetric/json.go 72.72% <ø> (+19.39%) ⬆️
pdata/pmetric/pb.go 100.00% <ø> (+28.57%) ⬆️
pdata/pmetric/pmetricotlp/grpc.go 100.00% <ø> (ø)
pdata/pmetric/pmetricotlp/request.go 61.11% <ø> (ø)
pdata/pmetric/pmetricotlp/response.go 12.50% <ø> (ø)
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Bogdan <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu merged commit 2ed8c0c into open-telemetry:main Oct 31, 2022
@bogdandrutu bogdandrutu deleted the providehelpers branch October 31, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants