Deprecate all types and funcs in config package #6422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 91.64% // Head: 91.86% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #6422 +/- ##
==========================================
+ Coverage 91.64% 91.86% +0.22%
==========================================
Files 238 238
Lines 13811 13616 -195
==========================================
- Hits 12657 12509 -148
+ Misses 924 878 -46
+ Partials 230 229 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
bogdandrutu
force-pushed
the
deprecateallconfig
branch
3 times, most recently
from
6f2fe5e
to
bee1ea8
Compare
|
/cc @dmitryax since I remember you also mentioned this to me |
|
This seems like a good solution to me. I was thinking about taking a similar approach. |
dmitryax
reviewed
Oct 31, 2022
codeboten
reviewed
Oct 31, 2022
bogdandrutu
force-pushed
the
deprecateallconfig
branch
from
bee1ea8
to
ea54801
Compare
|
@codeboten @dmitryax PTAL |
bogdandrutu
force-pushed
the
deprecateallconfig
branch
4 times, most recently
from
0e5bded
to
0a8f738
Compare
bogdandrutu
force-pushed
the
deprecateallconfig
branch
2 times, most recently
from
798755c
to
7ef05a3
Compare
Done. |
bogdandrutu
force-pushed
the
deprecateallconfig
branch
from
967dc86
to
c2fd7b9
Compare
dmitryax
reviewed
Nov 1, 2022
bogdandrutu
force-pushed
the
deprecateallconfig
branch
from
0d78abd
to
59948fc
Compare
dmitryax
approved these changes
Nov 2, 2022
codeboten
approved these changes
Nov 2, 2022
The main reason is to remove the circular dependency between the config (including sub-packages) and component. Here is the current state: * component depends on config * config/sub-package[grpc, http, etc.] depends on config & component Because of this "circular" dependency, we cannot split for example "config" into its own module, only if all the other config sub-packages are also split. Signed-off-by: Bogdan <bogdandrutu@gmail.com>
Signed-off-by: Bogdan <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
deprecateallconfig
branch
from
59948fc
to
dd19a00
Compare
Signed-off-by: Bogdan <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
deprecateallconfig
branch
from
dd19a00
to
74e53c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main reason is to remove the circular dependency between the config (including sub-packages) and component. Here is the current state:
Because of this "circular" dependency, we cannot split for example "config" into its own module, only if all the other config sub-packages are also split.
Updates #6187