Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hack to continue to read protobuf id 1000 in the resource messages #6342

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

bogdandrutu
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Base: 92.04% // Head: 92.05% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (180e237) compared to base (4d44580).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6342      +/-   ##
==========================================
+ Coverage   92.04%   92.05%   +0.01%     
==========================================
  Files         219      219              
  Lines       13244    13265      +21     
==========================================
+ Hits        12190    12211      +21     
  Misses        830      830              
  Partials      224      224              
Impacted Files Coverage Δ
pdata/internal/otlp/logs.go 100.00% <100.00%> (ø)
pdata/internal/otlp/metrics.go 100.00% <100.00%> (ø)
pdata/internal/otlp/traces.go 100.00% <100.00%> (ø)
pdata/plog/json.go 100.00% <0.00%> (ø)
pdata/ptrace/json.go 82.35% <0.00%> (+2.35%) ⬆️
pdata/pmetric/json.go 82.35% <0.00%> (+2.35%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have some test coverage, but given it's hack for to support deprecated fields, It's probably good to go as is

Signed-off-by: Bogdan <bogdandrutu@gmail.com>
@bogdandrutu
Copy link
Member Author

It would be nice to have some test coverage, but given it's hack for to support deprecated fields, It's probably good to go as is

Done.

@bogdandrutu bogdandrutu merged commit 55f7c24 into open-telemetry:main Oct 18, 2022
@bogdandrutu bogdandrutu deleted the addhack branch October 14, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants