Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pdata] Rename plog.SeverityNumberUndefined to SeverityNumberUnspecified #6269

Merged

Conversation

dmitryax
Copy link
Member

For consistency with other enum zero constants based on protobuf enums.

Updates #6256

@dmitryax dmitryax requested review from a team and jpkrohling October 10, 2022 18:39
For consistency with other enum zero constants based on protobuf enums.
@dmitryax dmitryax force-pushed the rename-SeverityNumberUndefined branch from fb00744 to 559bad9 Compare October 10, 2022 18:39
@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Base: 92.30% // Head: 92.30% // No change to project coverage 👍

Coverage data is based on head (559bad9) compared to base (06db057).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6269   +/-   ##
=======================================
  Coverage   92.30%   92.30%           
=======================================
  Files         219      219           
  Lines       13455    13455           
=======================================
  Hits        12419    12419           
  Misses        806      806           
  Partials      230      230           
Impacted Files Coverage Δ
pdata/plog/logs.go 96.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bogdandrutu bogdandrutu merged commit 4e6286c into open-telemetry:main Oct 10, 2022
@dmitryax dmitryax deleted the rename-SeverityNumberUndefined branch October 11, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants