Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change AggregationTemporality.String to simpler, easier to read #6117

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan bogdandrutu@gmail.com

@bogdandrutu bogdandrutu requested review from a team and Aneurysm9 September 19, 2022 15:57
@bogdandrutu bogdandrutu force-pushed the aggregationtemp branch 2 times, most recently from a0f5287 to ddd3102 Compare September 19, 2022 16:01
@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Base: 92.17% // Head: 92.19% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (57775b6) compared to base (8efcb44).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6117      +/-   ##
==========================================
+ Coverage   92.17%   92.19%   +0.01%     
==========================================
  Files         219      219              
  Lines       13488    13495       +7     
==========================================
+ Hits        12433    12442       +9     
+ Misses        825      823       -2     
  Partials      230      230              
Impacted Files Coverage Δ
pdata/pmetric/metrics.go 100.00% <100.00%> (+2.46%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2022

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 4, 2022
@dmitryax
Copy link
Member

dmitryax commented Oct 4, 2022

Please resolve the conflicts

Signed-off-by: Bogdan <bogdandrutu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants