Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete deprecated config.Unmarshalable interface #6084

Merged
merged 2 commits into from
Sep 15, 2022
Merged

Delete deprecated config.Unmarshalable interface #6084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72656a6
Delete deprecated config.Unmarshalable interface
bogdandrutu Sep 15, 2022
dfae48f
Merge branch 'main' into unmarshalable
bogdandrutu Sep 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@

### 🛑 Breaking changes 🛑

- Delete deprecated `config.Unmarshalable` interface. (#6084)
- Delete deprecated `p[metric|log|trace].MarshalerSizer` interfaces (#6083)


## v0.60.0 Beta

### 🛑 Breaking changes 🛑
Expand Down
4 changes: 1 addition & 3 deletions config/common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
// limitations under the License.

package config // import "go.opentelemetry.io/collector/config"

import (
"go.opentelemetry.io/collector/confmap"
)
Expand All @@ -26,9 +27,6 @@ type validatable interface {
Validate() error
}

// Deprecated: [v0.60.0] use confmap.Unmarshaler.
type Unmarshallable = confmap.Unmarshaler

// DataType is a special Type that represents the data types supported by the collector. We currently support
// collecting metrics, traces and logs, this can expand in the future.
type DataType = Type
Expand Down