Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mismatch go.sum between make gotidy and make genotelcorecol #5116

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

rleungx
Copy link
Contributor

@rleungx rleungx commented Mar 30, 2022

Signed-off-by: Ryan Leung rleungx@gmail.com

Description: Just as the title says.

Link to tracking Issue: #5113

Testing: Manual test by running make gotidy and make genotelcorecol

@rleungx rleungx requested review from a team and codeboten March 30, 2022 07:15
@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #5116 (4a4c46c) into main (0f07b0b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #5116   +/-   ##
=======================================
  Coverage   89.93%   89.93%           
=======================================
  Files         183      183           
  Lines       11104    11104           
=======================================
  Hits         9986     9986           
  Misses        892      892           
  Partials      226      226           
Impacted Files Coverage Δ
cmd/builder/internal/builder/main.go 59.74% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f07b0b...4a4c46c. Read the comment docs.

@bogdandrutu bogdandrutu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 30, 2022
@bogdandrutu bogdandrutu merged commit 4036157 into open-telemetry:main Mar 30, 2022
@jpkrohling
Copy link
Member

I'm pretty sure the "all" was added later to fix another problem. Could you please check git blame for this line?

@rleungx
Copy link
Contributor Author

rleungx commented Mar 31, 2022

I'm pretty sure the "all" was added later to fix another problem. Could you please check git blame for this line?

Yes. The original PR is open-telemetry/opentelemetry-collector-builder#50, but it seems to be unnecessary.
The problem it's going to solve is that we need to update the modules before building which open-telemetry/opentelemetry-collector-builder#20 solved. And open-telemetry/opentelemetry-collector-builder#66 add tidy command before download in GetModules. So I think we even don't need a download here. I'm not sure if I have the right understanding.

Nicholaswang pushed a commit to Nicholaswang/opentelemetry-collector that referenced this pull request Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants