Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pipeline key with pipeline identifier to processor loggers #4968

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

Aneurysm9
Copy link
Member

Signed-off-by: Anthony J Mirabella a9@aneurysm9.com

@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #4968 (9372a28) into main (f980c9e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4968   +/-   ##
=======================================
  Coverage   90.99%   90.99%           
=======================================
  Files         178      178           
  Lines       10632    10633    +1     
=======================================
+ Hits         9675     9676    +1     
  Misses        739      739           
  Partials      218      218           
Impacted Files Coverage Δ
service/internal/builder/pipelines_builder.go 87.76% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f980c9e...9372a28. Read the comment docs.

@Aneurysm9 Aneurysm9 changed the title Add pipeline key with pipeline identifier to component loggers Add pipeline key with pipeline identifier to processor loggers Mar 8, 2022
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
@jpkrohling
Copy link
Member

Is there an issue tracking this? Looks sane, but I would love to understand what triggered this.

@Aneurysm9
Copy link
Member Author

Is there an issue tracking this? Looks sane, but I would love to understand what triggered this.

It was triggered by a message in #otel-collector slack. It's a bit unfortunate that there doesn't seem to be a good way to tie pipelines to the exporters or receivers they use, but given that they can be part of multiple pipelines having the component name in the logger is probably the best we can do there.

@codeboten codeboten merged commit f21243a into open-telemetry:main Mar 8, 2022
Nicholaswang pushed a commit to Nicholaswang/opentelemetry-collector that referenced this pull request Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants