[pdata] Rename NumberDataPoint/Exemplar.Type methods to ValueType
#4850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4850 +/- ##
=======================================
Coverage 90.74% 90.75%
=======================================
Files 180 180
Lines 10593 10597 +4
=======================================
+ Hits 9613 9617 +4
Misses 762 762
Partials 218 218
Continue to review full report at Codecov.
|
dmitryax
force-pushed
the
rename-value-type
branch
2 times, most recently
from
6551321
to
c8e9769
Compare
dmitryax
changed the title
NumberDataPoint.Type() and Exemplar.Type()NumberDataPoint/Exemplar.Type methods to ValueType
dmitryax
force-pushed
the
rename-value-type
branch
from
c8e9769
to
77a5f7a
Compare
Deprecate `NumberDataPoint.Type()` and `Exemplar.Type()` in favor of `NumberDataPoint.ValueType()` and `Exemplar.ValueType()` instead. Do not use accessorType in the pdatagen, always rely on proto field type for consistency.
dmitryax
force-pushed
the
rename-value-type
branch
from
77a5f7a
to
ab9994e
Compare
bogdandrutu
approved these changes
Feb 11, 2022
codeboten
approved these changes
Feb 11, 2022
bogdandrutu
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new
NumberDataPoint.ValueType()andExemplar.ValueType()instead. Do not useaccessorTypein the pdatagen, always rely on proto field type for consistency.Resolves #4781