Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extension/zpages] Add feature gate summary page #4834

Merged
merged 3 commits into from
Feb 14, 2022

Conversation

Aneurysm9
Copy link
Member

Signed-off-by: Anthony J Mirabella a9@aneurysm9.com

@Aneurysm9 Aneurysm9 requested review from a team and jpkrohling February 10, 2022 01:38
@Aneurysm9 Aneurysm9 force-pushed the feat/zpages/featureGates branch 2 times, most recently from 47ab80b to 1e43bfc Compare February 10, 2022 01:40
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #4834 (f3b9edf) into main (ea897a6) will decrease coverage by 0.14%.
The diff coverage is 28.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4834      +/-   ##
==========================================
- Coverage   90.74%   90.60%   -0.15%     
==========================================
  Files         180      180              
  Lines       10593    10618      +25     
==========================================
+ Hits         9613     9620       +7     
- Misses        762      779      +17     
- Partials      218      219       +1     
Impacted Files Coverage Δ
service/internal/zpages/templates.go 41.66% <25.00%> (-2.09%) ⬇️
service/zpages.go 70.33% <28.57%> (-9.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea897a6...f3b9edf. Read the comment docs.

Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a link to http://localhost:55679/debug/featurez somewhere? It would also be good to have a mention of it in the readme.

Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
@Aneurysm9
Copy link
Member Author

Should there be a link to http://localhost:55679/debug/featurez somewhere? It would also be good to have a mention of it in the readme.

I added a link to servicez as it seems like the closest thing to a landing page.

@bogdandrutu
Copy link
Member

Do you have a screenshot of the page?

@Aneurysm9
Copy link
Member Author

It will look very empty right now as there aren't any feature gates defined in the core repo, but I added a few to demonstrate:

Screen Shot 2022-02-10 at 19 17 55

@bogdandrutu bogdandrutu merged commit 1765388 into open-telemetry:main Feb 14, 2022
@Aneurysm9 Aneurysm9 deleted the feat/zpages/featureGates branch February 14, 2022 17:45
@jpkrohling jpkrohling added this to the v0.45.0 milestone Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants