Rename pdata.AnyValueArray to AttributeSlice

[Aneurysm9]

Signed-off-by: Anthony J Mirabella a9@aneurysm9.com

[codecov]

Codecov Report

Merging #4325 (431c966) into main (7e4a7e3) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #4325   +/-   ##
=======================================
  Coverage   88.13%   88.13%           
=======================================
  Files         176      176           
  Lines       10425    10425           
=======================================
  Hits         9188     9188           
  Misses       1005     1005           
  Partials      232      232           

Impacted Files	Coverage Δ
internal/otlptext/databuffer.go	100.00% <100.00%> (ø)
model/pdata/common.go	95.14% <100.00%> (ø)
model/pdata/generated_common.go	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e4a7e3...431c966. Read the comment docs.

[bogdandrutu]

LGTM in general except that small inconsistency, can be done in a separate PR but we need to confirm the names here.

[codeboten]

Thanks for addressing my comments!

[bogdandrutu]

Will not merge until contrib is green with what is merged in main. It means someone needs to upgrade contrib to pass with the current main before this gets merged to not have more than one breaking change to fix.

[tigrannajaryan]

Since the PR is fixing names I feel compelled to comment on naming despite 3 approvals :-)

AttributeSlice doesn't seem like a good name for an array of values. This is not a slice of attributes. Attributes are key/value pairs. This is a slice of AnyValue. May be call it AttributeValueSlice? (a bit too long IMO).

I believe attribute means a distinct thing and this uses the term incorrectly.

[bogdandrutu]

@tigrannajaryan sounds good to me AttributeValueSlice what about the other funcs on AttributeValue? is ok to use SliceVal?

[tigrannajaryan]

@tigrannajaryan sounds good to me AttributeValueSlice what about the other funcs on AttributeValue? is ok to use SliceVal?

Yes, I think it is fine to rename Array->Slice.

[Aneurysm9]

What then of AttributeMap? It stores *[]otlpcommon.KeyValue whose values are AnyValue.

[bogdandrutu]

AttributeMap stores attributes, every entry has a "key" and a "AnyValue"

[bogdandrutu]

So I think the mapping is:

• otlpcommon.KeyValue => Attribute
• otlpcommon.AnyValue => AttributeValue