Remove protocol-specific authenticator interfaces #4255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pavankrish123, would you like to take a look at this one? |
Codecov Report
@@ Coverage Diff @@
## main #4255 +/- ##
==========================================
+ Coverage 88.07% 88.22% +0.15%
==========================================
Files 173 173
Lines 10188 10320 +132
==========================================
+ Hits 8973 9105 +132
Misses 975 975
Partials 240 240
Continue to review full report at Codecov.
|
This PR removes the gRPC and HTTP-specific interfaces from the client authenticators. Implementations should now comply with the main top-level interface, which defines the functions previously defined at the individual interfaces. Fixes open-telemetry#4239 Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
jpkrohling
force-pushed
the
jpkrohling/issue4239
branch
from
4f7ff00
to
14d9b55
Compare
pavankrish123
approved these changes
Oct 25, 2021
There was a problem hiding this comment.
LGTM! Thanks.
Opened issue open-telemetry/opentelemetry-collector-contrib#5904 and corresponding PR open-telemetry/opentelemetry-collector-contrib#5905 for corresponding (Minor) changes that have to be made on the client authentication implementation modules.
codeboten
reviewed
Oct 25, 2021
bogdandrutu
approved these changes
Oct 26, 2021
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the gRPC and HTTP-specific interfaces from the client authenticators. Implementations should now comply with the main top-level interface, which defines the functions previously defined at the individual interfaces.
Fixes #4239
Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de