Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obsreport: wire up ReceiverCreateSettings for receivers using obsreport #4149

Merged

Conversation

Aneurysm9
Copy link
Member

Signed-off-by: Anthony J Mirabella a9@aneurysm9.com>

Link to tracking Issue: #3922

Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
@Aneurysm9 Aneurysm9 requested review from a team and codeboten September 29, 2021 22:58
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #4149 (9987cb4) into main (190f8fb) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4149      +/-   ##
==========================================
+ Coverage   87.70%   87.77%   +0.06%     
==========================================
  Files         173      173              
  Lines       10257    10282      +25     
==========================================
+ Hits         8996     9025      +29     
+ Misses       1011     1007       -4     
  Partials      250      250              
Impacted Files Coverage Δ
obsreport/obsreport_receiver.go 100.00% <100.00%> (ø)
obsreport/obsreport_scraper.go 100.00% <100.00%> (ø)
receiver/otlpreceiver/internal/logs/otlp.go 100.00% <100.00%> (ø)
receiver/otlpreceiver/internal/metrics/otlp.go 100.00% <100.00%> (ø)
receiver/otlpreceiver/internal/trace/otlp.go 100.00% <100.00%> (ø)
receiver/otlpreceiver/otlp.go 79.57% <100.00%> (ø)
receiver/scraperhelper/scraper.go 100.00% <100.00%> (ø)
receiver/scraperhelper/scrapercontroller.go 93.40% <100.00%> (+0.38%) ⬆️
obsreport/obsreporttest/obsreporttest.go 65.73% <0.00%> (+2.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 190f8fb...9987cb4. Read the comment docs.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion, code looks good 👍

obsreport/obsreport_test.go Outdated Show resolved Hide resolved
@bogdandrutu bogdandrutu merged commit 2209f2a into open-telemetry:main Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants