Change TLSClient config to pointer type #4104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrannajaryan
approved these changes
Sep 27, 2021
| if tlsCfg != nil { | ||
| transport.TLSClientConfig = tlsCfg | ||
|
|
||
| if hcs.TLSSetting != nil { |
There was a problem hiding this comment.
There seems to be some inconsistency between how gRPC and HTTP handle nil tls section. gRPC looks at the scheme to decide whether to enable tls, HTTP does not do that.
Would be good to fix in a separate PR to make sure gRPC and HTTP clients behave the same way.
codeboten
pushed a commit
to codeboten/opentelemetry-collector
that referenced
this pull request
Oct 13, 2021
This reverts commit ebb0fbd.
bogdandrutu
pushed a commit
that referenced
this pull request
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: <Describe what has changed.
Change TLSClient config to pointer type in
confighttpandconfiggrpcconfigRelated Issue
#4028
#4063 (comment)