Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ServiceExtension to just Extension #2581

Merged
merged 2 commits into from
Mar 5, 2021

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu requested a review from a team March 2, 2021 23:31
@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #2581 (2859460) into main (1269d20) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2581   +/-   ##
=======================================
  Coverage   92.03%   92.03%           
=======================================
  Files         273      273           
  Lines       15455    15455           
=======================================
  Hits        14224    14224           
  Misses        849      849           
  Partials      382      382           
Impacted Files Coverage Δ
component/componenttest/error_waiting_host.go 100.00% <ø> (ø)
component/componenttest/example_factories.go 88.14% <ø> (ø)
component/componenttest/nop_host.go 100.00% <ø> (ø)
extension/extensionhelper/factory.go 100.00% <ø> (ø)
extension/fluentbitextension/factory.go 100.00% <ø> (ø)
extension/healthcheckextension/factory.go 100.00% <ø> (ø)
extension/pprofextension/factory.go 87.50% <ø> (ø)
extension/zpagesextension/factory.go 87.50% <ø> (ø)
service/service.go 52.67% <ø> (ø)
service/builder/extensions_builder.go 80.76% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1269d20...2859460. Read the comment docs.

Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, why did we call it ServiceExtension in the first place? Was it conflicting with something else at the time?

@bogdandrutu
Copy link
Member Author

@tigrannajaryan no idea, but it was inconsistent with everything else.

@bogdandrutu bogdandrutu merged commit 7cdbd1c into open-telemetry:main Mar 5, 2021
@bogdandrutu bogdandrutu deleted the serviceext branch March 5, 2021 19:26
This was referenced Mar 11, 2021
This was referenced Mar 15, 2021
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
…etry#2581)

Bumps [pygithub](https://github.com/pygithub/pygithub) from 1.57 to 1.58.0.
- [Release notes](https://github.com/pygithub/pygithub/releases)
- [Changelog](https://github.com/PyGithub/PyGithub/blob/master/doc/changes.rst)
- [Commits](PyGithub/PyGithub@v1.57...v1.58.0)

---
updated-dependencies:
- dependency-name: pygithub
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants