-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup usage of TimestampUnixNanos and its API #2549
Conversation
c231b80
to
f9dea87
Compare
Codecov Report
@@ Coverage Diff @@
## main #2549 +/- ##
==========================================
- Coverage 91.69% 91.68% -0.01%
==========================================
Files 266 266
Lines 15111 15101 -10
==========================================
- Hits 13856 13846 -10
Misses 871 871
Partials 384 384
Continue to review full report at Codecov.
|
f9dea87
to
f80a3c6
Compare
Looks good, except maybe change of behavior for zero time. We had a bug which was fixed by this. I don't remember what exactly, maybe try digging using git blame to see when was it introduced. |
Even if we fixed other bug, we did that by adding a new bug because IsZero on the time package means year 1 not 1970 |
@tigrannajaryan I think it was a simple bug added by myself #1550 |
Updates open-telemetry#2488 Important Changes: * Rename pdata.TimestampUnixNanos to pdata.Timestamp * Remove pdata.TimestampUnixNanos and helpers, move them of the pdata.Timestamp type. * Fix bug around IsZero, this function should return true if the time is January 1, year 1, 00:00:00 UTC not epoch. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
f80a3c6
to
e9a4c2a
Compare
Updates #2488
Important Changes: