Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated function IsValid from trace/span ID #2522

Merged
merged 1 commit into from
Feb 22, 2021
+4 −12
Merged

Remove deprecated function IsValid from trace/span ID #2522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

## 🛑 Breaking changes 🛑

- Remove deprecated function `IsValid` from trace/span ID (#2522)

## v0.20.0 Beta

## 🛑 Breaking changes 🛑
Expand Down
6 changes: 0 additions & 6 deletions consumer/pdata/spanid.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,6 @@ func (t SpanID) HexString() string {
return data.SpanID(t).HexString()
}

// IsValid returns true if id contains at leas one non-zero byte.
// Deprecated: use !IsEmpty() instead.
func (t SpanID) IsValid() bool {
return !data.SpanID(t).IsEmpty()
}

// IsEmpty returns true if id doesn't contain at least one non-zero byte.
func (t SpanID) IsEmpty() bool {
return data.SpanID(t).IsEmpty()
Expand Down
6 changes: 0 additions & 6 deletions consumer/pdata/traceid.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,6 @@ func (t TraceID) HexString() string {
return data.TraceID(t).HexString()
}

// IsValid returns true if id contains at leas one non-zero byte.
// Deprecated: use !IsEmpty() instead.
func (t TraceID) IsValid() bool {
return !data.TraceID(t).IsEmpty()
}

// IsEmpty returns true if id doesn't contain at least one non-zero byte.
func (t TraceID) IsEmpty() bool {
return data.TraceID(t).IsEmpty()
Expand Down