Rename StartTime/EndTime to StartTimestamp/EndTimestamp

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+## 🛑 Breaking changes 🛑
+
+- Rename pdata.TimestampUnixNano to Timestamp, move helpers on the type itself #2514
+
 ## v0.20.0 Beta
 
 ## 🛑 Breaking changes 🛑

cmd/pdatagen/internal/common_structs.go

@@ -72,31 +72,31 @@ var instrumentationLibraryField = &messageValueField{
 	returnMessage:   instrumentationLibrary,
 }
 
-var startTimeField = &primitiveTypedField{
-	fieldName:       "StartTime",
+var startTimestampField = &primitiveTypedField{
+	fieldName:       "StartTimestamp",
 	originFieldName: "StartTimeUnixNano",
-	returnType:      "TimestampUnixNano",
+	returnType:      "Timestamp",
 	rawType:         "uint64",
-	defaultVal:      "TimestampUnixNano(0)",
-	testVal:         "TimestampUnixNano(1234567890)",
+	defaultVal:      "Timestamp(0)",
+	testVal:         "Timestamp(1234567890)",
 }
 
 var timeField = &primitiveTypedField{
 	fieldName:       "Timestamp",
 	originFieldName: "TimeUnixNano",
-	returnType:      "TimestampUnixNano",
+	returnType:      "Timestamp",
 	rawType:         "uint64",
-	defaultVal:      "TimestampUnixNano(0)",
-	testVal:         "TimestampUnixNano(1234567890)",
+	defaultVal:      "Timestamp(0)",
+	testVal:         "Timestamp(1234567890)",
 }
 
-var endTimeField = &primitiveTypedField{
-	fieldName:       "EndTime",
+var endTimestampField = &primitiveTypedField{
+	fieldName:       "EndTimestamp",
 	originFieldName: "EndTimeUnixNano",
-	returnType:      "TimestampUnixNano",
+	returnType:      "Timestamp",
 	rawType:         "uint64",
-	defaultVal:      "TimestampUnixNano(0)",
-	testVal:         "TimestampUnixNano(1234567890)",
+	defaultVal:      "Timestamp(0)",
+	testVal:         "Timestamp(1234567890)",
 }
 
 var attributes = &sliceField{

cmd/pdatagen/internal/log_structs.go

@@ -88,10 +88,10 @@ var logRecord = &messageValueStruct{
 		&primitiveTypedField{
 			fieldName:       "Timestamp",
 			originFieldName: "TimeUnixNano",
-			returnType:      "TimestampUnixNano",
+			returnType:      "Timestamp",
 			rawType:         "uint64",
-			defaultVal:      "TimestampUnixNano(0)",
-			testVal:         "TimestampUnixNano(1234567890)",
+			defaultVal:      "Timestamp(0)",
+			testVal:         "Timestamp(1234567890)",
 		},
 		traceIDField,
 		spanIDField,

cmd/pdatagen/internal/metrics_structs.go

@@ -235,7 +235,7 @@ var intDataPoint = &messageValueStruct{
 	originFullName: "otlpmetrics.IntDataPoint",
 	fields: []baseField{
 		labelsField,
-		startTimeField,
+		startTimestampField,
 		timeField,
 		valueInt64Field,
 		intExemplarsField,
@@ -253,7 +253,7 @@ var doubleDataPoint = &messageValueStruct{
 	originFullName: "otlpmetrics.DoubleDataPoint",
 	fields: []baseField{
 		labelsField,
-		startTimeField,
+		startTimestampField,
 		timeField,
 		valueFloat64Field,
 		doubleExemplarsField,
@@ -271,7 +271,7 @@ var intHistogramDataPoint = &messageValueStruct{
 	originFullName: "otlpmetrics.IntHistogramDataPoint",
 	fields: []baseField{
 		labelsField,
-		startTimeField,
+		startTimestampField,
 		timeField,
 		countField,
 		intSumField,
@@ -292,7 +292,7 @@ var doubleHistogramDataPoint = &messageValueStruct{
 	originFullName: "otlpmetrics.DoubleHistogramDataPoint",
 	fields: []baseField{
 		labelsField,
-		startTimeField,
+		startTimestampField,
 		timeField,
 		countField,
 		doubleSumField,
@@ -313,7 +313,7 @@ var doubleSummaryDataPoint = &messageValueStruct{
 	originFullName: "otlpmetrics.DoubleSummaryDataPoint",
 	fields: []baseField{
 		labelsField,
-		startTimeField,
+		startTimestampField,
 		timeField,
 		countField,
 		doubleSumField,

cmd/pdatagen/internal/trace_structs.go

@@ -105,8 +105,8 @@ var span = &messageValueStruct{
 			defaultVal:      "SpanKindUNSPECIFIED",
 			testVal:         "SpanKindSERVER",
 		},
-		startTimeField,
-		endTimeField,
+		startTimestampField,
+		endTimestampField,
 		attributes,
 		droppedAttributesCount,
 		&sliceField{

consumer/pdata/common.go

@@ -19,19 +19,10 @@ package pdata
 
 import (
 	"sort"
-	"time"
 
 	otlpcommon "go.opentelemetry.io/collector/internal/data/protogen/common/v1"
 )
 
-// TimestampUnixNano is a time specified as UNIX Epoch time in nanoseconds since
-// 00:00:00 UTC on 1 January 1970.
-type TimestampUnixNano uint64
-
-func (ts TimestampUnixNano) String() string {
-	return time.Unix(0, int64(ts)).String()
-}
-
 // AttributeValueType specifies the type of AttributeValue.
 type AttributeValueType int