Add disk/weighted_io_time metric (Linux only) #2312
Conversation
james-bebbington
force-pushed
the
weighted-io-time
branch
5 times, most recently
from
31c0def
to
9791dc0
Compare
james-bebbington
force-pushed
the
weighted-io-time
branch
from
9791dc0
to
63d28e7
Compare
Codecov Report
@@ Coverage Diff @@
## master #2312 +/- ##
==========================================
+ Coverage 92.00% 92.03% +0.02%
==========================================
Files 273 273
Lines 15332 15384 +52
==========================================
+ Hits 14106 14158 +52
Misses 845 845
Partials 381 381
Continue to review full report at Codecov.
|
| @@ -72,7 +72,7 @@ var resourceMetrics = []string{ | |||
| } | |||
|
|
|||
| var systemSpecificMetrics = map[string][]string{ | |||
| "linux": {"system.disk.merged", "system.filesystem.inodes.usage", "system.paging.faults", "system.processes.created", "system.processes.count"}, | |||
| "linux": {"system.disk.merged", "system.disk.weighted_io_time", "system.filesystem.inodes.usage", "system.paging.faults", "system.processes.created", "system.processes.count"}, | |||
There was a problem hiding this comment.
do we have specs for this? If no we should at least have an issue to track this in the specs.
There was a problem hiding this comment.
@aabmass This metric, system.disk.weighted_io_time, is specific to Linux, although system.disk.merged is as well, and that is currently in the spec (here).
Should these metrics actually be prefixed with system.linux. as per the guidance here or should we make an exception for these two relatively generic metrics that are not easily measurable on other OSs and add system.disk.weighted_io_time to the specs as well?
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Add disk/weighted_io_time metric (Linux only)