-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[filterprocessor] filter metrics using resource attributes #2251
[filterprocessor] filter metrics using resource attributes #2251
Conversation
Signed-off-by: Rayhan Hossain <hossain.rayhan@outlook.com>
Signed-off-by: Rayhan Hossain <hossain.rayhan@outlook.com>
Codecov Report
@@ Coverage Diff @@
## master #2251 +/- ##
==========================================
+ Coverage 92.00% 92.03% +0.02%
==========================================
Files 273 273
Lines 15391 15405 +14
==========================================
+ Hits 14161 14178 +17
+ Misses 849 846 -3
Partials 381 381
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am asking for changes because I want to avoid duplicate code.
Signed-off-by: Rayhan Hossain <hossain.rayhan@outlook.com>
Signed-off-by: Rayhan Hossain <hossain.rayhan@outlook.com>
Signed-off-by: Rayhan Hossain <hossain.rayhan@outlook.com>
Signed-off-by: Rayhan Hossain <hossain.rayhan@outlook.com>
Hi @bogdandrutu, could you have another look on this. |
Hi @bogdandrutu, I saw that you resolved our improvement conversation, thanks. Is there any other feedback to make it better or we are good to go? Would be great if we can merge it before holidays. 😄 |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Hi @bogdandrutu, happy new year! would you have a final look on this? |
Description:
New Feature: This contribution adds the capability of filtering metrics using resource attributes.
Current filter processor can include/exclude metrics based on metric_name field. However, It would be good if we can filter metrics using metric_name and resource attributes together. For example, we have
container.cpu.utilized
metrics and it comes from three different containers. Customer cares about metrics from only one container and want to exclude other two. All the metrics have a resource attributecontainer.id
and we want to filter the metrics using this field.Link to tracking Issue:
#2050
Testing:
Unit test added.
Manually tested using logging exporter.
Documentation:
README updated with example.