Add support to skip TLS verification #2202
Conversation
Follow up from open-telemetry#933 where InsecureSkipVerify was discussed but not implemented.
|
|
Codecov Report
@@ Coverage Diff @@
## master #2202 +/- ##
==========================================
- Coverage 92.01% 91.99% -0.03%
==========================================
Files 271 271
Lines 15783 15784 +1
==========================================
- Hits 14523 14520 -3
- Misses 858 860 +2
- Partials 402 404 +2
Continue to review full report at Codecov.
|
|
Can you please sign the CLA? |
Yes, I'm trying to add our organisation to EasyCLA but there's some issues where the page just gets stuck loading. I'm not our CLA manager but will try this again soon and if the issue persist I guess I'll have to file an issue using the link the bot provided. |
|
I sent a fix #2204 for the coverage flakiness, thanks for pointing that it is confusing, made me fix it :) |
|
Still no success having the CLA manager to join the company so I filed a support ticket to LFX help center. Will sign as soon as I'm able to associate my account with my organisation. |
|
@bogdandrutu Sorry for the delay, it was a pain to get the CLA setup working with CLA managers and whatnot. But it should be all OK now! 😸 |
|
@bogdandrutu Thank you so much for the quick merge! How do you usually handle release cycles? Could I expect a v0.15.1 in a near future or will you release v0.16.0 in a month or so? |
…pen-telemetry#2202) * s/ValueRecorder/Histogram/g * s/ValueObserver/GaugeObserver/g * s/UpDownSumObserver/UpDownCounterObserver/g * s/SumObserver/CounterObserver/g * changelog * pr num * unstable->experimental * Apply suggestions from code review Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> * Apply suggestions from code review * apply feedback from @evantorrie by hand * Apply suggestions from code review Thanks Co-authored-by: ET <evantorrie@users.noreply.github.com> * Update sdk/export/metric/metric.go * Apply suggestions from code review Thank you @evantorrie ! Co-authored-by: ET <evantorrie@users.noreply.github.com> * revert getting-started fix let tyler's update remove this text * more variable name fixes * test repair Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> Co-authored-by: ET <evantorrie@users.noreply.github.com> Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
* Bump aquasecurity/trivy-action from 0.7.1 to 0.8.0 Bumps [aquasecurity/trivy-action](https://github.com/aquasecurity/trivy-action) from 0.7.1 to 0.8.0. - [Release notes](https://github.com/aquasecurity/trivy-action/releases) - [Commits](aquasecurity/trivy-action@0.7.1...0.8.0) --- updated-dependencies: - dependency-name: aquasecurity/trivy-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * update flagged golang.org/x dependencies Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ryan Fitzpatrick <rfitzpatrick@splunk.com>
Follow up from #933 where InsecureSkipVerify was discussed but not
implemented.
Description: Add support to set
InsecureSkipVerifytotls.Config. This will use a secure connection whichInsecuredoes not, however it will not verify the certificate.Link to tracking Issue: No issue but followup on #933.
Testing: Added test for the configuration to ensure settings were properly set.
Documentation: Updated
configtlsREADME with example./cc @ccaraman