Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cloud.provider semantic conventions #1865

Merged
merged 1 commit into from
Sep 29, 2020
Merged

Add cloud.provider semantic conventions #1865

merged 1 commit into from
Sep 29, 2020

Conversation

jrcamp
Copy link
Contributor

@jrcamp jrcamp commented Sep 25, 2020

@tigrannajaryan
Copy link
Member

Can we wait for spec to be merged? Are you blocked?

tigrannajaryan
tigrannajaryan approved these changes Sep 28, 2020
View reviewed changes
Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spec is approved, it is only a matter of time until it is merged, so approving this.

@tigrannajaryan tigrannajaryan merged commit c8622d2 into open-telemetry:master Sep 29, 2020
@jrcamp jrcamp deleted the cloud-provider branch September 29, 2020 22:00
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
@gliptak @MrAlias
CI builds validate against last two versions of Go, dropping 1.14 and…
d20e722 
… adding 1.16 (open-telemetry#1865)

Signed-off-by: Gábor Lipták <gliptak@gmail.com>

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tigrannajaryan tigrannajaryan tigrannajaryan approved these changes

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu

@dmitryax dmitryax Awaiting requested review from dmitryax

@james-bebbington james-bebbington Awaiting requested review from james-bebbington

@nilebox nilebox Awaiting requested review from nilebox

@owais owais Awaiting requested review from owais

@pjanotti pjanotti Awaiting requested review from pjanotti

Assignees

@tigrannajaryan tigrannajaryan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrcamp @tigrannajaryan