Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate OpenCensus-based internal data structures #1843

Conversation

tigrannajaryan
Copy link
Member

All new code must use the new pdata.* structures.

TODO: move a few remaining functions that translate between
OpenCensus-data and pdata to OpenCensus packages.

All new code must use the new pdata.* structures.

TODO: move a few remaining functions that translate between
OpenCensus-data and pdata to OpenCensus packages.
@codecov
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

Merging #1843 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1843   +/-   ##
=======================================
  Coverage   91.16%   91.16%           
=======================================
  Files         271      271           
  Lines       16235    16235           
=======================================
  Hits        14801    14801           
  Misses       1008     1008           
  Partials      426      426           
Impacted Files Coverage Δ
translator/internaldata/metrics_to_oc.go 91.17% <ø> (ø)
translator/internaldata/oc_to_metrics.go 91.97% <ø> (ø)
translator/internaldata/oc_to_traces.go 85.46% <ø> (ø)
translator/internaldata/traces_to_oc.go 86.53% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 430c002...75897d6. Read the comment docs.

@tigrannajaryan tigrannajaryan merged commit 8690937 into open-telemetry:master Sep 24, 2020
@tigrannajaryan tigrannajaryan deleted the feature/tigran/deprecate-oc-data-types branch September 24, 2020 16:10
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants