POC for how to avoid duplicating WithStart and WithShutdown #12466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (74.19%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #12466 +/- ##
==========================================
- Coverage 92.10% 92.04% -0.06%
==========================================
Files 465 465
Lines 25180 25200 +20
==========================================
+ Hits 23191 23195 +4
- Misses 1592 1608 +16
Partials 397 397 ☔ View full report in Codecov by Sentry. |
ms-jcorley
approved these changes
Feb 24, 2025
| StartFunc: bs.StartFunc, | ||
| ShutdownFunc: bs.ShutdownFunc, | ||
| Logs: logsConsumer, | ||
| Component: component.NewComponent(bs.componentOptions...), |
There was a problem hiding this comment.
tiny nit: The abbreviated name of this "bs" variable isn't clear entirely clear here (metrics.go and traces.go also use it). The other files use names that are clearer from context.
|
This looks alright to me, I think we can apply it everywhere |
codeboten
reviewed
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, we allow in the future to add more options in the component that will automatically be picked by every component implementation, as well as we remove duplicate definition.