Deprecate all Scraper helpers in scraperhelper #11732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
commented
Nov 22, 2024
| @@ -63,14 +57,8 @@ type baseScraper struct { | |||
| ScrapeFunc | |||
| } | |||
|
|
|||
| // NewScraper creates a scraper.Metrics that calls ScrapeMetrics at the specified collection interval, | |||
| // reports observability information, and passes the scraped metrics to the next consumer. | |||
| func NewScraper(scrape ScrapeFunc, options ...ScraperOption) (scraper.Metrics, error) { | |||
There was a problem hiding this comment.
Not breaking change because not released yet.
bogdandrutu
force-pushed
the
dep-more-scrapers
branch
from
f130499 to
db7e301
Compare
bogdandrutu
commented
Nov 22, 2024
| type ScrapeFunc func(context.Context) (pmetric.Metrics, error) | ||
|
|
||
| func (sf ScrapeFunc) ScrapeMetrics(ctx context.Context) (pmetric.Metrics, error) { |
dmitryax
approved these changes
Nov 22, 2024
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
dep-more-scrapers
branch
from
db7e301 to
c0fec8a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11732 +/- ##
==========================================
- Coverage 91.61% 91.54% -0.08%
==========================================
Files 442 443 +1
Lines 23764 23764
==========================================
- Hits 21772 21754 -18
- Misses 1620 1637 +17
- Partials 372 373 +1 ☔ View full report in Codecov by Sentry. |
codeboten
approved these changes
Nov 25, 2024
HongChenTW
pushed a commit
to HongChenTW/opentelemetry-collector
that referenced
this pull request
Dec 19, 2024
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.