-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore][docs] Add code owners policy #11557
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11557 +/- ##
=======================================
Coverage 91.53% 91.53%
=======================================
Files 441 441
Lines 23922 23922
=======================================
Hits 21896 21896
Misses 1650 1650
Partials 376 376 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need similar tooling to what is in contrib to populate the CODEOWNERS file?
Yeah, I think that would be helpful, but we can work on this independently of the actual policy, right? |
Filed #11562 for the tooling stuff |
Thanks @mx-psi, yup this can be done separately |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@open-telemetry/collector-maintainers Will merge this on Monday since we had already discussed this. Please block before then if you have objections! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing that we discussed offline and may worth commenting. The approver from codeowners is "recommended" but not "required".
This is already the de facto way things work in contrib, will file a PR to clarify there as well
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description <!-- Issue number if applicable --> Adds code owner policy. #### Link to tracking issue Fixes open-telemetry#11550
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description <!-- Issue number if applicable --> Adds code owner policy. #### Link to tracking issue Fixes open-telemetry#11550
Description
Adds code owner policy.
Link to tracking issue
Fixes #11550