[telemetry] rename memorylimiter metrics to include memory_limiter infix #11280
Conversation
* deprecated metrics used exclusively in memory limiter processor now have an infix of `memory_limiter`.
* metrics were properly updated in generated files. The change in the test file is a linting thing, ordering alphabetically. I left as it was a result of the make command but it can be removed if necessary.
| @@ -30,7 +30,7 @@ telemetry: | |||
| value_type: int | |||
| monotonic: true | |||
|
|
|||
| processor_accepted_spans: | |||
| processor_memory_limiter_accepted_spans: | |||
There was a problem hiding this comment.
These metrics will need to be moved to the memorylimiter's metadata configuration https://github.com/open-telemetry/opentelemetry-collector/blob/main/processor/memorylimiterprocessor/metadata.yaml
With the existing metrics staying deprecated for another few versions in the processorhelper
There was a problem hiding this comment.
Ah yep makes sense. I'm going to put this back to draft to make updates
There was a problem hiding this comment.
Please build your PR on top of #11289, since we want to remove the deprecated funcs and also starts the "metadata" part.
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Sorry y'all this fell off my radar, will pick it back up this week. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Description
Deprecated metrics used exclusively in memory limiter processor now have an infix of
memory_limiter. For example,otelcol_processor_accepted_spansis nowotelcol_processor_memory_limiter_accepted_spans.Some tests also got formatting updates during themake generateandmake mdatagen-teststeps, happy to remove them if preferred.Edit: 🤔 Actually that seems to fail tests, so I've reverted those changes. I saw the suggestion to run
mdatagen-testin themdatagenREADME, but maybe that should be updated (and/or changes made to prevent the formatting change?)Link to tracking issue
Documentation
Auto-generated documentation has been updated