Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[confighttp]: add an option to add span prefix #11230

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

VihasMakwana
Copy link
Contributor

@VihasMakwana VihasMakwana commented Sep 20, 2024

Description

This PR adds a new server option to modify span prefix.
it also updates otlpreceiver to use the option.

Link to tracking issue

Fixes #9382

Testing

Added.


component.ID is not available in this section of code. Since ToServer is intended to be general and can be used by extensions, receivers, and exporters, modifying it to accept internal.Settings would introduce a breaking change, which I'm not comfortable with. Therefore, I believe it would be better to provide an option to change the prefix instead.

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.80%. Comparing base (0c7d347) to head (c871eaf).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
receiver/otlpreceiver/otlp.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11230      +/-   ##
==========================================
- Coverage   91.81%   91.80%   -0.01%     
==========================================
  Files         424      424              
  Lines       20088    20098      +10     
==========================================
+ Hits        18443    18451       +8     
- Misses       1267     1268       +1     
- Partials      378      379       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VihasMakwana
Copy link
Contributor Author

@bogdandrutu @open-telemetry/collector-approvers I'd appreciate your review on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[config/confighttp] Resolve the TODO on confighttp.go related to prefixing operations with component id.
1 participant