Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate service::telemetry::metrics::address #11205

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Sep 17, 2024

Existing configs like:

service:
  telemetry:
    metrics:
      level: "basic"
      address: "localhost:8888"

Should change to:

service:
  telemetry:
    metrics:
      level: "basic"
      readers:
        - pull:
            exporter:
              prometheus:
                host: "localhost"
                port: 8888

service/service_test.go Outdated Show resolved Hide resolved
service/telemetry/config.go Outdated Show resolved Hide resolved
service/telemetry/config.go Show resolved Hide resolved
service/telemetry/config.go Show resolved Hide resolved
@bogdandrutu bogdandrutu force-pushed the deprecate-address branch 2 times, most recently from a401c44 to b0f645c Compare September 19, 2024 17:51
@bogdandrutu bogdandrutu force-pushed the deprecate-address branch 5 times, most recently from c20a687 to bd2798d Compare September 23, 2024 19:06
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 86.48649% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@d6f568d). Learn more about missing BASE report.

Files with missing lines Patch % Lines
service/telemetry/config.go 85.18% 2 Missing and 2 partials ⚠️
service/telemetry/metrics.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11205   +/-   ##
=======================================
  Coverage        ?   91.52%           
=======================================
  Files           ?      424           
  Lines           ?    20200           
  Branches        ?        0           
=======================================
  Hits            ?    18489           
  Misses          ?     1326           
  Partials        ?      385           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants