Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] update internal dep #11180

Merged

Conversation

codeboten
Copy link
Contributor

This is done to allow contrib dependencies to work. Otherwise, otelcoltest ends up picking up an old dependency that looks for localhostgate which has been removed.

Here's an example error:

go: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/azureeventhubreceiver tested by
	github.com/open-telemetry/opentelemetry-collector-contrib/receiver/azureeventhubreceiver.test imports
	go.opentelemetry.io/collector/otelcol/otelcoltest imports
	go.opentelemetry.io/collector/otelcol imports
	go.opentelemetry.io/collector/service tested by
	go.opentelemetry.io/collector/service.test imports
	go.opentelemetry.io/collector/config/confighttp imports
	go.opentelemetry.io/collector/config/internal imports
	go.opentelemetry.io/collector/internal/localhostgate: package go.opentelemetry.io/collector/internal/localhostgate provided by go.opentelemetry.io/collector at latest version v0.109.0 but not at required version v0.109.1-0.20240916143658-74729e731d3b

This is done to allow contrib dependencies to work. Otherwise, otelcoltest ends up picking up an old dependency that looks for localhostgate which has been removed.

Here's an example error:

```
go: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/azureeventhubreceiver tested by
	github.com/open-telemetry/opentelemetry-collector-contrib/receiver/azureeventhubreceiver.test imports
	go.opentelemetry.io/collector/otelcol/otelcoltest imports
	go.opentelemetry.io/collector/otelcol imports
	go.opentelemetry.io/collector/service tested by
	go.opentelemetry.io/collector/service.test imports
	go.opentelemetry.io/collector/config/confighttp imports
	go.opentelemetry.io/collector/config/internal imports
	go.opentelemetry.io/collector/internal/localhostgate: package go.opentelemetry.io/collector/internal/localhostgate provided by go.opentelemetry.io/collector at latest version v0.109.0 but not at required version v0.109.1-0.20240916143658-74729e731d3b
```

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten requested review from a team and bogdandrutu September 16, 2024 16:58
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.28%. Comparing base (74729e7) to head (fec01f5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11180   +/-   ##
=======================================
  Coverage   92.28%   92.28%           
=======================================
  Files         413      413           
  Lines       19761    19761           
=======================================
  Hits        18237    18237           
  Misses       1152     1152           
  Partials      372      372           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codeboten codeboten merged commit d3a1718 into open-telemetry:main Sep 16, 2024
47 of 48 checks passed
@codeboten codeboten deleted the codeboten/update-dep-sept16 branch September 16, 2024 17:14
@github-actions github-actions bot added this to the next release milestone Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants