Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mdatagen] add stability detail for metrics #11160

Merged
merged 7 commits into from
Sep 17, 2024

Conversation

codeboten
Copy link
Contributor

This allows component authors to specify the stability level of telemetry emitted by components. This provides visibility to end users as to what they can expect from the telemetry.

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.83%. Comparing base (51f321a) to head (387129c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/mdatagen/internal/loader.go 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11160      +/-   ##
==========================================
- Coverage   91.84%   91.83%   -0.02%     
==========================================
  Files         415      415              
  Lines       19850    19856       +6     
==========================================
+ Hits        18232    18235       +3     
- Misses       1245     1248       +3     
  Partials      373      373              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codeboten codeboten marked this pull request as ready for review September 13, 2024 23:26
@codeboten codeboten requested review from a team and bogdandrutu September 13, 2024 23:26
This allows component authors to specify the stability level
of telemetry emitted by components. This provides visibility to
end users as to what they can expect from the telemetry.

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten merged commit d5215c5 into open-telemetry:main Sep 17, 2024
47 of 49 checks passed
@codeboten codeboten deleted the codeboten/stability-metrics branch September 17, 2024 18:44
@github-actions github-actions bot added this to the next release milestone Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants