Honor build_tags in config #11156
Merged
Honor build_tags in config #11156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newly12
force-pushed
the
ocb_build_tags
branch
from
e801610
to
6f23c51
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11156 +/- ##
==========================================
+ Coverage 91.84% 91.85% +0.01%
==========================================
Files 416 416
Lines 19925 19926 +1
==========================================
+ Hits 18301 18304 +3
+ Misses 1246 1245 -1
+ Partials 378 377 -1 ☔ View full report in Codecov by Sentry. |
newly12
force-pushed
the
ocb_build_tags
branch
from
6f23c51
to
fc0e27a
Compare
bogdandrutu
approved these changes
Sep 12, 2024
bogdandrutu
reviewed
Sep 12, 2024
| @@ -209,5 +209,6 @@ func applyCfgFromFile(flags *flag.FlagSet, cfgFromFile builder.Config) { | |||
| if !flags.Changed(distributionModuleFlag) && cfgFromFile.Distribution.Module != "" { | |||
| cfg.Distribution.Module = cfgFromFile.Distribution.Module | |||
| } | |||
| cfg.Distribution.BuildTags = cfgFromFile.Distribution.BuildTags | |||
There was a problem hiding this comment.
Do you mind having some unittests?
mx-psi
approved these changes
Sep 19, 2024
jackgopack4
pushed a commit
to jackgopack4/opentelemetry-collector
that referenced
this pull request
Sep 19, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description <!-- Issue number if applicable --> #### Link to tracking issue Fixes # <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link to tracking issue
Fixes #
Testing
Documentation