Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add marshal calls to fuzzers #11119

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Conversation

AdamKorcz
Copy link
Contributor

Description

Link to tracking issue

Fixes #

Testing

Documentation

Adds both a marshal call and another unmarshal -> marshal round to the fuzzers to test for more potential bugs.

@AdamKorcz AdamKorcz requested review from a team and djaglowski September 10, 2024 18:19
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.85%. Comparing base (59c083f) to head (6701a45).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11119   +/-   ##
=======================================
  Coverage   91.85%   91.85%           
=======================================
  Files         416      416           
  Lines       19925    19925           
=======================================
  Hits        18302    18302           
  Misses       1245     1245           
  Partials      378      378           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codeboten codeboten added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 11, 2024
@djaglowski
Copy link
Member

LGTM but mispell lint is failling on: "marshalling is a misspelling of marshaling (misspell)"

pdata/plog/fuzz_test.go Outdated Show resolved Hide resolved
Signed-off-by: Adam Korczynski <adam@adalogics.com>
@mx-psi mx-psi merged commit a0d5966 into open-telemetry:main Sep 18, 2024
47 of 49 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 18, 2024
jackgopack4 pushed a commit to jackgopack4/opentelemetry-collector that referenced this pull request Sep 19, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

<!-- Issue number if applicable -->
#### Link to tracking issue
Fixes #

<!--Describe what testing was performed and which tests were added.-->
#### Testing

<!--Describe the documentation added.-->
#### Documentation

Adds both a marshal call and another unmarshal -> marshal round to the
fuzzers to test for more potential bugs.

<!--Please delete paragraphs that you did not use before submitting.-->

Signed-off-by: Adam Korczynski <adam@adalogics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants