use MeterProvider via the config package #11079
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the Collector to configure the MeterProvider via the config package instead of its own configuration. This allows us to remove a bunch of code that is duplicated, and to add support for views pretty quickly as a result, with very little code. Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
|
This is waiting on open-telemetry/opentelemetry-go-contrib#6126 |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
|
the work in this PR will be done in #11458 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the Collector to configure the MeterProvider via the config package instead of its own configuration. This allows us to remove a bunch of code that is duplicated, and to add support for views pretty quickly as a result, with very little code.
Leaving this in draft, until the config package can support an exclude filter for configuring stream attribute keys as described in open-telemetry/opentelemetry-specification#4188