[exporter/logging] Add warning to logging exporter #11050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
added
the
Skip Changelog
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11050 +/- ##
=======================================
Coverage 92.22% 92.23%
=======================================
Files 409 405 -4
Lines 19134 19089 -45
=======================================
- Hits 17646 17606 -40
+ Misses 1127 1123 -4
+ Partials 361 360 -1 ☔ View full report in Codecov by Sentry. |
songy23
approved these changes
Sep 4, 2024
bogdandrutu
approved these changes
Sep 4, 2024
codeboten
approved these changes
Sep 4, 2024
bogdandrutu
reviewed
Sep 4, 2024
| @@ -44,6 +44,7 @@ func createDefaultConfig() component.Config { | |||
| } | |||
|
|
|||
| func createTracesExporter(ctx context.Context, set exporter.Settings, config component.Config) (exporter.Traces, error) { | |||
| set.TelemetrySettings.Logger.Warn("The logging exporter is DEPRECATED and will be REMOVED in v0.111.0. Use the debug exporter instead: https://github.com/open-telemetry/opentelemetry-collector/tree/main/exporter/debugexporter") | |||
There was a problem hiding this comment.
Would it make sense to actually have a feature gate, we fail if not enabled? that way we signal even more?
There was a problem hiding this comment.
This message has been emitted for close to a year:
2024-09-04T09:11:09.411-0700 info builders/builders.go:26 Deprecated component. Will be removed in future releases. {"kind": "exporter", "data_type": "metrics", "name": "logging"}
But I understand this is a component that has been documented/used widely. Maybe it makes sense for this component to use a feature gate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add warning to logging exporter on startup to remind users to switch to the debug exporter.
Link to tracking issue
Related to #11037
Testing